Merged
Conversation
Originally installed with EasyBuild 2.3
This was referenced Mar 23, 2017
Merged
wpoely86
approved these changes
Mar 23, 2017
|
|
||
| # add additional configopts based on available dependencies | ||
| for key in deps: | ||
| if deps[key]: |
Member
There was a problem hiding this comment.
why this if? Can it not be avoided?
Member
Author
There was a problem hiding this comment.
some dependencies are optional, so some of these may be None
| # source tarballs contains a 'plugins' and 'vmd-<version>' directory | ||
| vmddir = os.path.join(self.cfg['start_dir'], '%s-%s' % (self.name.lower(), self.version)) | ||
|
|
||
| # first, build plugins |
Member
Author
There was a problem hiding this comment.
well, I can provide a reference to the VMD docs, but that's how it should be done, see http://www.ks.uiuc.edu/Research/vmd/doxygen/compiling.html or http://robinbetz.com/blog/2015/01/08/compiling-vmd-with-python-support/
wpoely86
approved these changes
Mar 23, 2017
Member
Author
|
Tested with easybuilders/easybuild-easyconfigs#4391, good to go in as revised version of #879. Thanks for the review @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleaned up/enhanced version of the VMD easyblock contributed by @thiell in #879, works with VMD 1.9.3.
The CUDA/OptiX support added by @thiell should still work, but this has not been tested.