Skip to content

add easyblock for WRF-Fire#1153

Merged
boegel merged 4 commits intoeasybuilders:developfrom
boegel:WRF_Fire
Mar 28, 2017
Merged

add easyblock for WRF-Fire#1153
boegel merged 4 commits intoeasybuilders:developfrom
boegel:WRF_Fire

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 28, 2017

No description provided.

@boegel boegel added this to the 3.2.0 milestone Mar 28, 2017
Comment thread easybuild/easyblocks/w/wrf_fire.py Outdated

def configure_step(self):
"""Custom configuration procedure for WRF-Fire."""

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less whitespace?

Comment thread easybuild/easyblocks/w/wrf_fire.py Outdated
change_dir('WRFV3')

# define $NETCDF* for netCDF dependency
env.setvar('NETCDF', get_software_root('netCDF-Fortran'))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no check if it's loaded?

Comment thread easybuild/easyblocks/w/wrf_fire.py Outdated
qa = {
"Compile for nesting? (1=basic, 2=preset moves, 3=vortex following) [default 1]:": '1',
}
no_qa = [
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

singe line?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 28, 2017

Thanks for the review @wpoely86!

@boegel boegel merged commit d38dc43 into easybuilders:develop Mar 28, 2017
@boegel boegel deleted the WRF_Fire branch March 28, 2017 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants