enhance Python sanity check to check for Tkinter support if Tk is included as a dependency#1156
Merged
boegel merged 1 commit intoeasybuilders:developfrom Mar 30, 2017
Merged
Conversation
…luded as a dependency
wpoely86
approved these changes
Mar 30, 2017
1 task
Member
Author
|
Tested with handful of existing Python easyconfigs + easybuilders/easybuild-easyconfigs#4260, works fine as expected |
Member
Author
|
Thanks for the review @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sort of related to easybuilders/easybuild-easyconfigs#4260, where we are no longer included
Tkas a dependency to PythonI'm deliberately not enforcing the
Tkinteris not there ifTkis not included as a dependency, sinceTkmay be picked up from the OS (which may be deliberate via--filter-deps).