also build SARtools and Envisat tools for Doris#1161
Merged
boegel merged 2 commits intoeasybuilders:developfrom Apr 6, 2017
Merged
also build SARtools and Envisat tools for Doris#1161boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
Member
Author
|
@wpoely86 please review? |
wpoely86
reviewed
Apr 6, 2017
| self.cfg['buildopts'] = common_buildopts | ||
| self.cfg.update('buildopts', 'CC="%s"' % os.getenv('CXX')) | ||
| cflags = os.getenv('CFLAGS') + " -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE" | ||
| self.cfg.update('buildopts', 'CFLAGS="%s"' % cflags) |
Member
Author
There was a problem hiding this comment.
well, I need to define CFLAGS, but I should use the $CXXFLAGS value as defined by EasyBuild here, yes
| 'files': ['bin/cpx2ps', 'bin/doris', 'bin/plotcpm', 'bin/run'], | ||
| 'files': [os.path.join('bin', x) for x in ['cpx2ps', 'doris', 'plotcpm', 'run']] + | ||
| [os.path.join('bin', x) for x in ['bkconvert', 'cpxfiddle', 'flapjack', 'floatmult', 'wrap']] + | ||
| [os.path.join('bin', x) for x in ['envisat_dump_header', 'envisat_dump_data']], |
Member
There was a problem hiding this comment.
why not put them all in a list variable outside this dict?
Member
Author
There was a problem hiding this comment.
I grouped them by origin (Doris vs SARtools vs ENVISAT_TOOLS), I'll include a comment to make that clear
wpoely86
approved these changes
Apr 6, 2017
Member
Author
|
Thanks for the review @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up for #1154