include update statements for $CPATH and $*LIBRARY_PATH in generated module in numpy easyblock#1183
Merged
boegel merged 3 commits intoeasybuilders:developfrom May 22, 2017
Merged
Conversation
Contributor
|
I get: Did i make an error when hand editing my numpy.py or? |
Member
Author
|
@akesandgren You also need the change in https://github.com/hpcugent/easybuild-framework/pull/2229/files#diff-1b202be69819e7f06f809e80c73f7789R87 |
Contributor
|
Works, produces the needed CPATH/*LIBRARY_PATH extensinos. |
Contributor
|
And GPAW 0.11 builds with it (and there is no python-numpy from the OS this time) |
Contributor
|
I.e., works for me. |
wpoely86
approved these changes
May 22, 2017
Member
Author
|
Thanks for the review @wpoely86 and @akesandgren for testing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires easybuilders/easybuild-framework#2229