drop check for 'ipython' in sanity check of Anacdona easyblock, to also support Miniconda#1210
Merged
boegel merged 5 commits intoeasybuilders:eb331from Jul 10, 2017
Merged
Conversation
verdurin
requested changes
Jul 9, 2017
| """ | ||
| custom_paths = { | ||
| 'files': [os.path.join('bin', x) for x in ['2to3', 'conda', 'ipython', 'pydoc', 'python', 'sqlite3']], | ||
| 'files': [os.path.join('bin', x) for x in ['2to3', 'conda', , 'pydoc', 'python', 'sqlite3']], |
boegel
approved these changes
Jul 10, 2017
Member
|
Makes perfect sense to me, I doubt we're going to miss any installation problems with |
boegel
added a commit
to boegel/easybuild-easyblocks
that referenced
this pull request
Jul 10, 2017
boegel
added a commit
to boegel/easybuild-easyblocks
that referenced
this pull request
Jul 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have removed
ipythonfrom the sanity check so the existing anaconda easyblock supports installing both Anaconda and Miniconda (https://conda.io/miniconda.html)IMHO it makes sense that when installing conda as dependency of another tool we use Miniconda as it only includes the basics. Anaconda also includes other libraries which maybe are not needed. This would also help to reduce the size of the installdir which can also be helpful in case we generate containers in the future
I added a test easyconfig here easybuilders/easybuild-easyconfigs#4841