Skip to content

also define CUDA_ROOT env var pointing to install dir#1234

Merged
boegel merged 1 commit intoeasybuilders:developfrom
pescobar:cuda_root
Dec 6, 2017
Merged

also define CUDA_ROOT env var pointing to install dir#1234
boegel merged 1 commit intoeasybuilders:developfrom
pescobar:cuda_root

Conversation

@pescobar
Copy link
Copy Markdown
Member

No description provided.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 29, 2017

@pescobar For which software were you hitting this missing $CUDA_ROOT? A quick Google search seems to suggest this is software-specific (e.g. PyCUDA)?

@pescobar
Copy link
Copy Markdown
Member Author

pescobar commented Aug 29, 2017

@boegel I noticed that one of my users was hardcoding this env var in his bashrc and I thought it would be useful to define it in the module .

I thought it was a widely used env var but you are right that this is not a standard env var. Only few applications use it. I didn't notice it.

I think this PR can be discarded but it's also true that having this env var doesn't hurt

@boegel boegel added this to the 3.4.0 milestone Aug 29, 2017
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 29, 2017

@easybuilders/easybuild-easyblocks-maintainers Thoughts on this?

It indeed doesn't hurt to let CUDA modules define $CUDA_ROOT, even though it's not standard?

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 4, 2017

awaiting feedback from @easybuilders/easybuild-easyblocks-maintainers ...

@boegel boegel modified the milestones: 3.5.0, 3.4.0 Sep 4, 2017
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 6, 2017

I'll go ahead and include this, under the assumption that things won't blow up.

If they do, we'll hear about it soon enough...

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 5816a29 into easybuilders:develop Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants