Apply os.remove() also to links, instead of shutil.rmtree#1251
Merged
boegel merged 2 commits intoeasybuilders:developfrom Sep 19, 2017
Merged
Apply os.remove() also to links, instead of shutil.rmtree#1251boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
boegel
requested changes
Sep 18, 2017
| path = os.path.join(self.home_subdir_local, tree) | ||
| if os.path.isfile(path): | ||
| if os.path.isfile(path) or os.path.islink(path): | ||
| os.remove(path) |
Member
There was a problem hiding this comment.
use remove_file instead from filetools (we don't have a remove_dir yet, and if we do, we should also add a remove that wraps around both remove_file and remove_dir)
Member
|
Did a quick test with this in place, looks good, going in, thanks @damianam! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cancelled an installation and when trying again EB failed trying to pass a symlink to
shutil.rmtree. This should fix it.