fix handling of generate_standalone_module in SystemCompiler & SystemMPI easyblocks#1261
Merged
boegel merged 3 commits intoeasybuilders:developfrom Oct 11, 2017
Merged
fix handling of generate_standalone_module in SystemCompiler & SystemMPI easyblocks#1261boegel merged 3 commits intoeasybuilders:developfrom
boegel merged 3 commits intoeasybuilders:developfrom
Conversation
Member
Author
|
Required for tests to pass in easybuilders/easybuild-easyconfigs#413 |
boegel
requested changes
Oct 11, 2017
| elif self.cfg['name'] in ['ifort']: | ||
| guesses = EB_ifort.make_module_req_guess(self) | ||
| if self.compiler_prefix in ['/usr', '/usr/local']: | ||
| # Force off adding paths to module since unloading such a module would be a potential shell killer |
| guesses = EB_ifort.make_module_req_guess(self) | ||
| if self.compiler_prefix in ['/usr', '/usr/local']: | ||
| # Force off adding paths to module since unloading such a module would be a potential shell killer | ||
| self.log.warning("Ignoring option 'generate_standalone_module' since installation prefix is %s", |
Member
There was a problem hiding this comment.
maybe use print_warning rather than log.warning?
| self.compiler_prefix) | ||
| else: | ||
| raise EasyBuildError("I don't know how to generate module var guesses for %s", self.cfg['name']) | ||
| if self.cfg['name'] in ['GCC','GCCcore']: |
Member
There was a problem hiding this comment.
This should not be indented under else, should always be done regardless of compiler_prefix in /usr?
Member
There was a problem hiding this comment.
nvm, that's the whole point of the /usr check :)
boegel
approved these changes
Oct 11, 2017
Member
|
lgtm, thanks @ocaisa! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not overwrite option in easyconfig, instead ignore it and print an explanatory warning