Move initialisation in system compiler/mpi easyblocks to the prepare step#1282
Move initialisation in system compiler/mpi easyblocks to the prepare step#1282boegel merged 8 commits intoeasybuilders:developfrom
Conversation
| """Extra initialization: keep track of values that may change due to modifications to the version.""" | ||
| super(SystemCompiler, self).__init__(*args, **kwargs) | ||
|
|
||
| # fix installdir and module names (may differ because of changes to version) |
There was a problem hiding this comment.
@ocaisa This doesn't make sense (anymore?), since we didn't touch self.cfg['version'] at all? Neither did we before you reshuffled things (we only do in make_module_step and make_module_extend_modpath, but neither of those affect the module name or the install directory?
There was a problem hiding this comment.
I think I was just preserving what was originally there, I need to dig a bit to understand the issue. Do you mean that all of this can be moved to make_module_step?
There was a problem hiding this comment.
Ok, I think you are right, I can't see any any reason for the mns related stuff, we only need self.orig_version and self.orig_installdir
There was a problem hiding this comment.
Indeed, so let's trash it.
That was probably needed at some point when we fiddled with self.cfg['version'] earlier on rather than only in make_module_step.
| super(SystemCompiler, self).__init__(*args, **kwargs) | ||
|
|
||
| # Keep track of original values of vars that are subject to change, for restoring later. | ||
| # The version is determined/matched from the installation and the installdir is determined from the system (the original is used |
There was a problem hiding this comment.
line too long, fixed in ocaisa#13, should then be good to go in
fix long lines
Some of the initialisation in the
systemcompilerandsystemmpieasyblocks was done unnecessarily early and is causing test failures in the easyconfigs repo (see easybuilders/easybuild-easyconfigs#5242 (comment) ).Moving these initialisations to the
prepare_stepavoids these failures and also makes more sense.