Fixed wrong sanity check in boost when using python3#1283
Merged
boegel merged 3 commits intoeasybuilders:developfrom Nov 7, 2017
Merged
Fixed wrong sanity check in boost when using python3#1283boegel merged 3 commits intoeasybuilders:developfrom
boegel merged 3 commits intoeasybuilders:developfrom
Conversation
boegel
requested changes
Nov 6, 2017
| if int(pymajorver) >= 3: | ||
| custom_paths["files"].append('lib/libboost_python%s.%s' % (pymajorver, shlib_ext)) | ||
| else: | ||
| custom_paths["files"].append('lib/libboost_python.%s' % shlib_ext) |
Member
There was a problem hiding this comment.
To avoid copy-pasting, I'd prefer this:
pymajorver = get_software_version('Python').split('.')[0]
if int(pymajorver) >= 3:
suff = pymajorver
else:
suff = ''
custom_paths["files"].append('lib/libboost_python%s.%s' % (suff, shlib_ext))
boegel
approved these changes
Nov 7, 2017
Member
|
Strictly speaking, this fix is only needed for recent version of Boost (it's not needed for Boost 1.63.0 and earlier, it seems), but since So, going in, thanks @damianam! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.