set default java encoding to utf8 for Trinity#1302
Merged
boegel merged 2 commits intoeasybuilders:developfrom Dec 6, 2017
Merged
set default java encoding to utf8 for Trinity#1302boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
boegel
requested changes
Dec 5, 2017
|
|
||
| self.log.info("Begin Butterfly") | ||
|
|
||
| setvar("-Dfile.encoding", "UTF8") |
Member
There was a problem hiding this comment.
This looks wrong to me...
setvar is for defining environment variables, you are defining $-Dfile.encoding to UTF8 here, which is not what you want to do I'm guessing?
boegel
approved these changes
Dec 6, 2017
Member
|
Tested with existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to avoid compilation failure due to non-standard characters in java comments (see the Butterfly module).