Skip to content

enhance VMD easyblock to also build Surf & Stride + pick up netCDF for VMD >= 1.9.3#1314

Merged
boegel merged 9 commits intoeasybuilders:developfrom
akesandgren:add-support-for-newer-vmd-versions
May 8, 2019
Merged

enhance VMD easyblock to also build Surf & Stride + pick up netCDF for VMD >= 1.9.3#1314
boegel merged 9 commits intoeasybuilders:developfrom
akesandgren:add-support-for-newer-vmd-versions

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Dec 8, 2017

Add support for:

  • netCDF
  • Surf
  • Stride

houndci-bot
houndci-bot reviewed Sep 28, 2018
View reviewed changes
Comment thread easybuild/easyblocks/v/vmd.py Outdated
Comment thread easybuild/easyblocks/v/vmd.py Outdated
Comment thread easybuild/easyblocks/v/vmd.py Outdated
@boegel boegel added this to the next release milestone Oct 10, 2018
@akesandgren akesandgren changed the title Add support for newer versions of VMD. Add support for newer versions of VMD v3. Nov 8, 2018
@akesandgren akesandgren changed the title Add support for newer versions of VMD v3. Add support for newer versions of VMD Nov 8, 2018
boegel
boegel requested changes Dec 12, 2018
View reviewed changes
Comment thread easybuild/easyblocks/v/vmd.py
Comment thread easybuild/easyblocks/v/vmd.py Outdated
Comment thread easybuild/easyblocks/v/vmd.py Outdated
Comment thread easybuild/easyblocks/v/vmd.py Outdated
Comment thread easybuild/easyblocks/v/vmd.py Outdated
@boegel boegel modified the milestones: 3.8.0, 3.8.1 Dec 12, 2018
houndci-bot
houndci-bot reviewed Dec 13, 2018
View reviewed changes
Comment thread easybuild/easyblocks/v/vmd.py Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 14, 2018

@akesandgren Ran into this issue when rebuilding VMD-1.9.3-intel-2018b-Python-2.7.15.eb using this modified VMD easyblock:

== 2018-12-14 12:04:33,963 run.py:173 DEBUG run_cmd: running cmd make CC="icc" OPT="-O2 -xHost -ftz -fp-speculation=safe -fp-model source" (in /tmp/easybuild_build/VMD/1.9.3/intel-2018b-Python-2.7.15/vmd-1.9.3/lib/surf)
== 2018-12-14 12:04:33,963 run.py:192 INFO running cmd: make CC="icc" OPT="-O2 -xHost -ftz -fp-speculation=safe -fp-model source"
== 2018-12-14 12:04:34,225 build_log.py:162 ERROR EasyBuild crashed with an error (at ?:124 in __init__): cmd "make CC="icc" OPT="-O2 -xHost -ftz -fp-speculation=safe -fp-model source"" exited with exit code 2 and output:
make: *** No rule to make target `/usr/include/sgidefs.h', needed by `surf.o'.  Stop.

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Dec 14, 2018 •
edited
Loading

Oh, unexpected...

Ohh, need the new easyconfig too which patches that Makefile...

Which I apparently haven't made a PR of...

@akesandgren akesandgren mentioned this pull request Dec 14, 2018
Merged
@boegel boegel modified the milestones: 3.8.1, 3.9.0 Jan 19, 2019
@boegel boegel changed the title Add support for newer versions of VMD enhance VMD easyblock to also build Surf & Stride + pick up netCDF for VMD >= 1.9.3 May 5, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Changes tested with easybuilders/easybuild-easyconfigs#7305, lgtm, so going in, thanks @akesandgren!

@boegel boegel merged commit 454201b into easybuilders:develop May 8, 2019
@akesandgren akesandgren deleted the add-support-for-newer-vmd-versions branch May 8, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@bartoldeman bartoldeman Awaiting requested review from bartoldeman

+1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement merge sprint

Projects

None yet

Milestone

3.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@akesandgren @boegel @houndci-bot