Skip to content

update WPS easyblock for v3.6 & newer#1315

Merged
boegel merged 4 commits intoeasybuilders:developfrom
akesandgren:update-wps-for-newer-versions
Dec 13, 2019
Merged

update WPS easyblock for v3.6 & newer#1315
boegel merged 4 commits intoeasybuilders:developfrom
akesandgren:update-wps-for-newer-versions

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

Fix openmp support and a regex problem.

@boegel boegel added this to the next release milestone Oct 10, 2018
@akesandgren
Copy link
Copy Markdown
Contributor Author

@andreas-h Can you look at this old PR and see if it still applies after your recent updates. The target for this one is WPS v3

@akesandgren akesandgren changed the title Update wps.py for newer versions. Update wps.py for newer WPS v3 versions. Nov 8, 2018
@akesandgren
Copy link
Copy Markdown
Contributor Author

@andreas-h Ping??

@andreas-h
Copy link
Copy Markdown
Contributor

Not sure I can be of much help. I'm only building the dmpar build type, i.e. without OpenMP. Also I'm only using Intel toolchain. I was able to build WPS 3.8 with dmpar and Intel without any problems without this patch.

What I can do is test if this PR breaks my build of WPS 3.8 and 4.0 both using Intel and dmpar. I can also try foss but won't be able to debug thoroughly in case of trouble. All that next week.

1 similar comment
@andreas-h
Copy link
Copy Markdown
Contributor

Not sure I can be of much help. I'm only building the dmpar build type, i.e. without OpenMP. Also I'm only using Intel toolchain. I was able to build WPS 3.8 with dmpar and Intel without any problems without this patch.

What I can do is test if this PR breaks my build of WPS 3.8 and 4.0 both using Intel and dmpar. I can also try foss but won't be able to debug thoroughly in case of trouble. All that next week.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 14, 2018

@andreas-h Did you get a chance to test this?

@akesandgren Any easyconfig PRs that require this (so we have a test case)?

@boegel boegel modified the milestones: 3.8.0, 3.8.1 Dec 14, 2018
@akesandgren
Copy link
Copy Markdown
Contributor Author

I double checked and this fix is still relevant.
@boegel ??

@boegel boegel modified the milestones: 3.8.1, 3.9.0 Jan 19, 2019
@boegel boegel modified the milestones: next release (3.9.1), 3.x May 17, 2019
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested and approved

@boegel boegel changed the title Update wps.py for newer WPS v3 versions. update WPS easyblock for v3.6 & newer Dec 13, 2019
@boegel boegel merged commit e8dd325 into easybuilders:develop Dec 13, 2019
@akesandgren akesandgren deleted the update-wps-for-newer-versions branch December 13, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants