fix undefined variables used when running of parallel make in ScaLAPACK easyblock#1321
Merged
damianam merged 1 commit intoeasybuilders:developfrom Dec 12, 2017
Merged
Conversation
This was referenced Dec 12, 2017
Member
Author
|
This is properly tested now, fixes the issue reported in #1319 (after reproducing it first without the fix in place). |
damianam
approved these changes
Dec 12, 2017
Member
damianam
left a comment
There was a problem hiding this comment.
lgtm, but I'm kind of surprised it slipped through...
Member
Author
|
@damianam Frankly, so am I, I'm usually quite careful, but I messed up somehow... |
Member
|
It happens to the best. |
Contributor
|
Good - thanks for the quick resolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue reported by @olesenm in #1319.
This somehow slipped in #1288, despite my testing (I probably accidentally tested with an earlier version of that updated ScaLAPACK easyblock somehow...).