Skip to content

correctly ignore failure in attempt at parallel build in ScaLAPACK easyblock#1324

Merged
migueldiascosta merged 1 commit intoeasybuilders:3.5.xfrom
boegel:scalapack_parallel_build_fix
Dec 14, 2017
Merged

correctly ignore failure in attempt at parallel build in ScaLAPACK easyblock#1324
migueldiascosta merged 1 commit intoeasybuilders:3.5.xfrom
boegel:scalapack_parallel_build_fix

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 14, 2017

To actually ignore the exit code of a failing command, log_all needs to be set to False too, this was missing in #1288.

@boegel boegel added the bug fix label Dec 14, 2017
@boegel boegel added this to the 3.5.0 milestone Dec 14, 2017
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta migueldiascosta merged commit 318ba1e into easybuilders:3.5.x Dec 14, 2017
@boegel boegel deleted the scalapack_parallel_build_fix branch December 14, 2017 09:25
boegel added a commit to boegel/easybuild-easyblocks that referenced this pull request Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants