support install_target in PythonPackage + deprecate use_easy_install & use_setup_py_develop#1341
Conversation
|
@SethosII Can you add a clear deprecation log message when Something like: self.log.deprecated("Use 'install_target' rather than 'use_setup_py_develop'.", '4.0')The Ideally, we should also update easyconfigs in the central repo that use either
|
|
@boegel I added a deprecation message and also another commit to add the functionality from |
| @@ -186,6 +186,7 @@ def extra_options(extra_vars=None): | |||
| 'use_setup_py_develop': [False, "Install using '%s'" % SETUP_PY_DEVELOP_CMD, CUSTOM], | |||
There was a problem hiding this comment.
please add (deprecated) to the help message, same for use_easy_install
| else: | ||
| self.install_cmd = SETUP_PY_INSTALL_CMD | ||
|
|
||
| if self.cfg['install_target'] == 'easy_install': |
There was a problem hiding this comment.
introduce a EASY_INSTALL_TARGET constant on top, and use that (also use it to define EASY_INSTALL_INSTALL_CMD)
| self.cfg.update('installopts', '--no-deps') | ||
| if self.cfg.get('zipped_egg', False): | ||
| raise EasyBuildError("Installing zipped eggs requires using easy_install or pip") | ||
| if self.cfg['install_target'] == 'easy_install': |
There was a problem hiding this comment.
use EASY_INSTALL_TARGET here too
Add deprecated to options help message Add EASY_INSTALL_TARGET constant
|
@boegel I added the requested changes. |
|
Thanks a lot for your effort @SethosII! |
This makes the option passed to
setup.pyconfigurable. Thereforeuse_setup_py_developanduse_easy_installare obsolete.install_target = 'develop'andinstall_target = 'easy_install'can be used instead.See also easybuilders/easybuild-easyconfigs#5610 (comment).