Skip to content

Upgrade Ferret EasyBlock to Handle Ferret 7.3#1349

Merged
boegel merged 5 commits intoeasybuilders:developfrom
hajgato:ferret73
Jan 26, 2019
Merged

Upgrade Ferret EasyBlock to Handle Ferret 7.3#1349
boegel merged 5 commits intoeasybuilders:developfrom
hajgato:ferret73

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Jan 26, 2018

No description provided.

@hajgato hajgato mentioned this pull request Jan 26, 2018
Merged
boegel
boegel requested changes Jan 30, 2018
View reviewed changes
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
@boegel boegel added the update label Jan 30, 2018
@boegel boegel added this to the 3.x milestone Jan 30, 2018
@hajgato hajgato mentioned this pull request Jan 31, 2018
Closed
@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Jan 31, 2018

@boegel Code modernized using filetools

@boegel boegel modified the milestones: 3.x, 3.6.3 Jul 26, 2018
vanzod
vanzod previously approved these changes Sep 5, 2018
View reviewed changes
@vanzod
Copy link
Copy Markdown
Member

vanzod commented Sep 5, 2018

@boegel Ping?

@boegel boegel modified the milestones: 3.7.0, next release Sep 18, 2018
@boegel boegel modified the milestones: 3.7.1, next release Oct 10, 2018
@boegel boegel modified the milestones: 3.8.0, 3.x Dec 12, 2018
boegel
boegel requested changes Dec 14, 2018
View reviewed changes
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
Comment thread easybuild/easyblocks/f/ferret.py Outdated
@boegel boegel modified the milestones: 3.x, 3.8.1 Dec 14, 2018
@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Dec 17, 2018

@boegel done!

boegel
boegel previously approved these changes Jan 19, 2019
View reviewed changes
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 19, 2019

@hajgato Trouble in paradise:

$ eb --from-pr 5731 --include-easyblocks ferret.py
...
== configuring...
ERROR: Traceback (most recent call last):
  File "/kyukon/data/gent/vo/000/gvo00002/vsc40023/easybuild_easy_installed/lib/python2.6/site-packages/easybuild_framework-3.8.1.dev0-py2.7.egg/easybuild/main.py", line 112, in build_and_install_software
    (ec_res['success'], app_log, err) = build_and_install_one(ec, init_env)
  File "/data/gent/400/vsc40023/easybuild_easy_installed/lib/python2.7/site-packages/easybuild_framework-3.8.1.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 2866, in build_and_install_one
    result = app.run_all_steps(run_test_cases=run_test_cases)
  File "/data/gent/400/vsc40023/easybuild_easy_installed/lib/python2.7/site-packages/easybuild_framework-3.8.1.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 2776, in run_all_steps
    self.run_step(step_name, step_methods)
  File "/data/gent/400/vsc40023/easybuild_easy_installed/lib/python2.7/site-packages/easybuild_framework-3.8.1.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 2642, in run_step
    step_method(self)()
  File "/local/5112208.master15.delcatty.gent.vsc/eb-nlu1WE/included-easyblocks/easybuild/easyblocks/ferret.py", line 88, in configure_step
    apply_regex_substitutions(fn, regex_subs)
  File "/data/gent/400/vsc40023/easybuild_easy_installed/lib/python2.7/site-packages/easybuild_framework-3.8.1.dev0-py2.7.egg/easybuild/tools/filetools.py", line 1034, in apply_regex_substitutions
    for i, (regex, subtxt) in enumerate(regex_subs):
ValueError: need more than 1 value to unpack

@boegel boegel modified the milestones: 3.8.1, 3.9.0 Jan 19, 2019
@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Jan 21, 2019

@boegel Fixed.

boegel
boegel approved these changes Jan 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both with existing Ferret-6.72-goolf-1.4.10.eb and easybuilders/easybuild-easyconfigs#5731, works as expected, so good to go (to be included in EasyBuild v3.8.1), thanks @hajgato!

@boegel boegel modified the milestones: 3.9.0, 3.8.1 Jan 26, 2019
@boegel boegel merged commit 108b6ab into easybuilders:develop Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@vanzod vanzod vanzod left review comments

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

3.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@hajgato @vanzod @boegel