added option use_pip_for_deps for pythonpackages#1366
Merged
boegel merged 3 commits intoeasybuilders:developfrom Feb 26, 2018
Merged
added option use_pip_for_deps for pythonpackages#1366boegel merged 3 commits intoeasybuilders:developfrom
boegel merged 3 commits intoeasybuilders:developfrom
Conversation
boegel
requested changes
Feb 26, 2018
| self.log.info("Using pip with --no-deps option") | ||
| self.cfg.update('installopts', '--no-deps') | ||
| else: | ||
| self.log.info("Using pip to also install the dependencies") |
Member
There was a problem hiding this comment.
Checking == False is a bit weird @pescobar, since it's a boolean... Should be:
# don't auto-install dependencies with pip, unless use_pip_for_deps is enabled
if self.cfg.get('use_pip_for_deps'):
self.log.info("Using pip to also install the dependencies")
else:
self.log.info("Using pip with --no-deps option")
self.cfg.update('installopts', '--no-deps')| 'runtest': [True, "Run unit tests.", CUSTOM], # overrides default | ||
| 'use_easy_install': [False, "Install using '%s' (deprecated)" % EASY_INSTALL_INSTALL_CMD, CUSTOM], | ||
| 'use_pip': [False, "Install using '%s'" % PIP_INSTALL_CMD, CUSTOM], | ||
| 'use_pip_for_dependencies': [False, "Install dependencies using '%s'" % PIP_INSTALL_CMD, CUSTOM], |
boegel
approved these changes
Feb 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with this option a easyconfig like this one can be installed. The only change is
use_pip_for_deps = TrueI know this is not the recommended approach and it doesn't help to reproduce the same installation in the future but in this specific example deeptools requires 41 different python libraries so creating a proper easyconfig with all the required libraries require quite some manual work. And this is a tool that probably only 1 or 2 of my users will need so it's not worth the time IMHO and for me it's ok to take the risk of not writting a fully complete easyconfig with the complete list of deps and rely on pip for the installation but save a lot of time of manual work