enhanced CP2K easyblock, following Intel guidelines for ictce builds#138
Merged
boegel merged 26 commits intoeasybuilders:developfrom Mar 27, 2013
Merged
enhanced CP2K easyblock, following Intel guidelines for ictce builds#138boegel merged 26 commits intoeasybuilders:developfrom
boegel merged 26 commits intoeasybuilders:developfrom
Conversation
Member
Author
|
This fixes easybuilders/easybuild-framework#138 |
Member
Author
|
This pull request also fixes support for recent CP2K versions, in which directory structure of source was changed a bit. |
Contributor
|
@boegel besides the 2 small remarks, nice work! you should at the very least send an email to Hao Tijang (the author of the intel post), easybuild promo in the comments might be a bit of stretch though... |
…gure_ATLAS to configure_BLAS_lib
boegel
added a commit
that referenced
this pull request
Mar 27, 2013
enhanced CP2K easyblock, following Intel guidelines for ictce builds
Member
Author
|
Fixed remarks, so merging. |
This was referenced Mar 27, 2013
Closed
Contributor
There was a problem hiding this comment.
Very good code handling this one; this style should be used in each other easyblock, as well:
- It enhances orthogonality and allows to start using even things like cuBLAS and other uknown as of yet L.A. implementations (regardless if eg. cuBLAS makes sense in this case: it is always useful eg. to make performance comparison graphs among libs - and some future LA implementations will need to be handled too!)
APPLAUSE!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.