Added $EBROOTIFORT/include in CPATH#1385
Conversation
| guesses = super(EB_icc, self).make_module_req_guess() | ||
| if LooseVersion(self.version) >= LooseVersion('2016'): | ||
| # This enables the creation of fortran 2008 bindings in MPI | ||
| guesses['CPATH'].extend(['include']) |
There was a problem hiding this comment.
@damianam: Would it make sense to just add include in the initial CPATH list in EB_icc.make_module_req_guess instead?
<prefix>/include will only be added to $CPATH if it exists, so it's OK if it's also considered for icc
Also, style nitpicking: to add a single element, you should use append(x) rather than extend([x]) ;-)
There was a problem hiding this comment.
No, in $EBROOTICC/include there are some other headers, like complex.h, that apparently cause problems. Besides that, there is something fishy, the resulting module now is missing some paths in other variables. I'll try to take a look at it today.
There was a problem hiding this comment.
OK, thanks for clarifying, makes sense to only do this for ifort then.
I see no reason why other paths would suddenly go missing though...
| Additional paths to consider for prepend-paths statements in module file | ||
| """ | ||
| guesses = super(EB_icc, self).make_module_req_guess() | ||
| if LooseVersion(self.version) >= LooseVersion('2016'): |
There was a problem hiding this comment.
@damianam Why exactly is this version check here? If the include dir was not there for older versions, don't bother, the existence of the directory is checked before the path is added to $CPATH
There was a problem hiding this comment.
It existed, but the headers needed for fortran 2008 were not there, so there is no point in adding that path, I guess.
|
Thanks @damianam! |
This enables the creation of fortran 2008 bindings in MPI, for MPICH flavored MPIs