add custom easyblock for building and installing Lua#1396
Merged
ocaisa merged 5 commits intoeasybuilders:developfrom May 8, 2019
Merged
add custom easyblock for building and installing Lua#1396ocaisa merged 5 commits intoeasybuilders:developfrom
ocaisa merged 5 commits intoeasybuilders:developfrom
Conversation
boegel
requested changes
Apr 4, 2018
Contributor
Author
|
I fixed most of your suggestions. I find building the path of |
Contributor
Author
|
Is this ok? |
boegel
previously requested changes
May 22, 2018
luaconf.h to correctly insert path to Lua install
ocaisa
approved these changes
May 8, 2019
Member
ocaisa
left a comment
There was a problem hiding this comment.
Visually looks good, checking with one of the open PRs
boegel has since made changes directly to PR
Member
|
Confirmed working with easybuilders/easybuild-easyconfigs#8269 (comment) |
Contributor
Author
|
Well, most of the polish work was by @boegel. Thanks for taking care of the things I left out for me. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
luaconf.hfile needs to be patched in order forluato be able to find modules inside the correct install dir.