add support to enable integration of pscom in psmpi easyblock#1397
add support to enable integration of pscom in psmpi easyblock#1397boegel merged 3 commits intoeasybuilders:developfrom
Conversation
| pscom_allin_path = self.cfg['pscom_allin_path'].strip() | ||
| self.cfg.update('configopts', ' --with-pscom-allin="%s"' % pscom_allin_path) | ||
| self.cfg.update('preconfigopts', ('PSCOM_LDFLAGS=-L{0}/lib '+ | ||
| 'PSCOM_CPPFLAGS=-I{0}/include').format(pscom_allin_path)) |
There was a problem hiding this comment.
I would reformat this a bit for readability, and to avoid duplicate code:
if self.cfg['pscom_allin_path'] is None:
pscom_allin_path = get_software_root('pscom')
else:
pscom_allin_path = self.cfg['pscom_allin_path'].strip()
self.cfg.update('configopts', ' --with-pscom-allin="%s"' % pscom_allin_path)
pscom_flags = "PSCOM_LDFLAGS=-L{0}/lib PSCOM_CPPFLAGS=-I{0}/include".format(pscom_allin_path)
self.cfg.update('preconfigopts', pscom_flags)There was a problem hiding this comment.
Done in the next commit
| self.cfg.update('preconfigopts', ('PSCOM_LDFLAGS=-L{0}/lib '+ | ||
| 'PSCOM_CPPFLAGS=-I{0}/include').format(get_software_root('pscom'))) | ||
| else: | ||
| pscom_allin_path = self.cfg['pscom_allin_path'].strip() |
There was a problem hiding this comment.
Why do you need the .strip() here, that's a bit strange?
There was a problem hiding this comment.
Otherwise there was an empty space that messed up the definition of the variable
| extra_vars.update({ | ||
| 'mpich_opts': [None, "Optional options to configure MPICH", CUSTOM], | ||
| 'threaded': [False, "Enable multithreaded build (which is slower)", CUSTOM], | ||
| 'pscom_allin_path': [None, "Enable pscom integration by giving its source path", CUSTOM], |
There was a problem hiding this comment.
s/source path/installation prefix/ ?
There was a problem hiding this comment.
Well, it is an installation prefix just if it is installed, right? But with the allin option it is not really installed so....... I still think source path is "correcter"
|
I'm not sure I fully understand what this means? Is it that |
|
@ocaisa with this change |
This enables integration of pscom in psmpi build