set $CMAKE_*_PATH when CMake is loaded in PythonPackage easyblock#1398
Merged
boegel merged 1 commit intoeasybuilders:developfrom May 8, 2018
Merged
set $CMAKE_*_PATH when CMake is loaded in PythonPackage easyblock#1398boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
Member
|
@wpoely86 How does this relate to the |
Member
Author
|
It's different (I think) in the sense that you never directly call cmake. For the outside, it's an ordinary python package but internally it calls cmake. The |
Member
|
Makes sense, thanks for clarifying @wpoely86. I gave this a quick test with easyconfigs that could potentially be affected by this change (i.e. ones that combine |
boegel
approved these changes
May 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's is not a great nor a final solution but it already helps.
We should think how to handle this in the generic case? Wrapper for CMake in the PythonPackage block?