Skip to content

extend noqa in configure step of Qt easyblock#1409

Merged
migueldiascosta merged 1 commit intoeasybuilders:3.6.xfrom
boegel:qt_noqa
Apr 26, 2018
Merged

extend noqa in configure step of Qt easyblock#1409
migueldiascosta merged 1 commit intoeasybuilders:3.6.xfrom
boegel:qt_noqa

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 26, 2018

The configure step of Qt5 occasionally fails now, because it 'hangs' for a while, making run_cmd_qa think it's asking a question it doesn't know the answer to.

It seems like this happens when the last bit of output produced is Checking for <foo> ..., so we can make the Qt easyblock more robust by registering that in noqa to indicate it's not a question and more output is expected to come.

@boegel boegel added the bug fix label Apr 26, 2018
@boegel boegel added this to the 3.6.0 milestone Apr 26, 2018
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta migueldiascosta merged commit 93e6507 into easybuilders:3.6.x Apr 26, 2018
boegel added a commit to boegel/easybuild-easyblocks that referenced this pull request Apr 26, 2018
@boegel boegel deleted the qt_noqa branch April 26, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants