Install Chimera in a subdirectory to avoid its dependencies being added to the environment#1413
Merged
boegel merged 1 commit intoeasybuilders:developfrom May 21, 2018
Merged
Conversation
Installing Chimera in a subdirectory avoids its bundled dependencies being added to PATH, CPATH, LD_LIBRARY_PATH, etc. when Chimera's module is loaded. Chimera already comes with a startup wrapper script that handles adding its bundled dependencies to the environment.
Member
|
Thanks a lot for your contribution @sebth, sorry about the long wait for feedback... This looks perfect & well documented, I tested this myself and it works as expected, so good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when loading Chimera after loading Python, Python starts picking up the Tcl/Tk version that comes bundled with Chimera instead of the correct one. This PR fixes that by installing Chimera in a subdirectory so that the bundled dependencies are not added to PATH, LD_LIBRARY_PATH, etc. A symlink is added from 'bin/chimera' in the root directory to 'bin/chimera' in subdirectory, so that a 'chimera' command will exist in PATH. Chimera will still find its bundled dependencies, because it uses a wrapper startup script that adds them to the environment.
This method is similar to what they describe in the installation instructions at http://www.cgl.ucsf.edu/chimera/data/downloads/1.11.2/linux.html.