Skip to content

make sure xmlpatterns always gets built with Qt#1437

Merged
damianam merged 3 commits intoeasybuilders:developfrom
boegel:Qt_xmlpatterns
Jun 18, 2018
Merged

make sure xmlpatterns always gets built with Qt#1437
damianam merged 3 commits intoeasybuilders:developfrom
boegel:Qt_xmlpatterns

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 15, 2018

fix for easybuilders/easybuild-easyconfigs#6302

For some reason, xmlpatterns isn't always installed. Explicitly configuring for it seems to help though... This problem only seems to occur with Qt 4.x, the Qt5 installations I have all include bin/xmlpatterns

WIP since all existing Qt easyconfigs need to be retested to ensure they all still work...

@boegel boegel added the bug fix label Jun 15, 2018
@boegel boegel added this to the 3.6.2 milestone Jun 15, 2018
@easybuilders easybuilders deleted a comment from boegelbot Jun 15, 2018
@boegel boegel changed the title make sure xmlpatterns always gets built with Qt (WIP) make sure xmlpatterns always gets built with Qt Jun 18, 2018
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 18, 2018

no surprises after testing with existing Qt easyconfigs, good to go @damianam

@damianam
Copy link
Copy Markdown
Member

@boegel do you have the build reports for the existing Qt easyconfigs with this easyblock? Maybe it makes sense to start storing that for verification? It might be important as the codebase and number of contributors grow. Just food for thought, not that it is important now.

Copy link
Copy Markdown
Member

@damianam damianam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damianam damianam merged commit efa2511 into easybuilders:develop Jun 18, 2018
@boegel boegel deleted the Qt_xmlpatterns branch June 18, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants