Amber: Handle X11 better and make static a build flag.#1468
Merged
boegel merged 2 commits intoeasybuilders:developfrom Aug 21, 2018
Merged
Conversation
Also fix some lingering tabs.
damianam
previously requested changes
Aug 20, 2018
| env.setvar('GOTO', lapack) | ||
| lapack = os.getenv('LIBLAPACK') | ||
| if lapack is None: | ||
| raise EasyBuildError("LIBLAPACK (from OpenBLAS) not found in environement.") |
Member
There was a problem hiding this comment.
Since you are at it, while not fix typos like environement?
Contributor
Author
There was a problem hiding this comment.
as you wish :-)
boegel
approved these changes
Aug 21, 2018
Member
boegel
left a comment
There was a problem hiding this comment.
lgtm, tested with existing Amber easyconfig, good to go
This was referenced Oct 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix some lingering tabs.
Static handling taken from PR#1343
The zlib/bzip2 part is not needed from that PR.