make CUDA version check version dependent (only for v9.x & newer)#1483
Merged
boegel merged 2 commits intoeasybuilders:developfrom Aug 24, 2018
Merged
make CUDA version check version dependent (only for v9.x & newer)#1483boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
Member
|
@wpoely86 Turns out only checking for the CUDA version to enable the check is a bit optimistic... Installation of because of while the version is So better only enable the check when more than one source file is provided? |
Member
Author
|
That still will not help. If some easyconfigs use a different version scheme, there isn't much I can do? I can limit it to version 9 and newer which all use the same version convention? |
Member
|
@wpoely86 Fine by me, I don't expect we'll be installing CUDA 8.x with patches anyway... |
boegel
approved these changes
Aug 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up fix from #1481