Skip to content

make CUDA version check version dependent (only for v9.x & newer)#1483

Merged
boegel merged 2 commits intoeasybuilders:developfrom
wpoely86:cudapatches
Aug 24, 2018
Merged

make CUDA version check version dependent (only for v9.x & newer)#1483
boegel merged 2 commits intoeasybuilders:developfrom
wpoely86:cudapatches

Conversation

@wpoely86
Copy link
Copy Markdown
Member

Follow up fix from #1481

@wpoely86 wpoely86 changed the base branch from master to develop August 24, 2018 08:14
@boegel boegel added the bug fix label Aug 24, 2018
@boegel boegel added this to the 3.7.0 milestone Aug 24, 2018
boegel
boegel previously approved these changes Aug 24, 2018
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 24, 2018

@wpoely86 Turns out only checking for the CUDA version to enable the check is a bit optimistic...

Installation of CUDA-8.0.61_375.26-GCC-5.4.0-2.26.eb now fails with:

== FAILED: Installation ended unsuccessfully (build directory: /tmp/easybuild_build/CUDA/8.0.61_375.26/GCC-5.4.0-2.26): build failed (first 300 chars): Unable to find the correct version (8.0.61_375.26) in the version.txt file

because of

$ cat $EASYBUILD_PREFIX/software/CUDA/8.0.61_375.26-GCC-5.4.0-2.26/version.txt
CUDA Version 8.0.61

while the version is 8.0.61_375.26

So better only enable the check when more than one source file is provided?

@wpoely86
Copy link
Copy Markdown
Member Author

That still will not help. If some easyconfigs use a different version scheme, there isn't much I can do? I can limit it to version 9 and newer which all use the same version convention?

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 24, 2018

@wpoely86 Fine by me, I don't expect we'll be installing CUDA 8.x with patches anyway...

@boegel boegel changed the title Make cuda version check version dependant Make cuda version check version dependent Aug 24, 2018
@boegel boegel changed the title Make cuda version check version dependent make CUDA version check version dependent Aug 24, 2018
@boegel boegel changed the title make CUDA version check version dependent make CUDA version check version dependent (only for v9.x & newer) Aug 24, 2018
@boegel boegel merged commit c918953 into easybuilders:develop Aug 24, 2018
@wpoely86 wpoely86 deleted the cudapatches branch August 24, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants