IMPROVE PGI siterc so it allows -pthread switch#1494
IMPROVE PGI siterc so it allows -pthread switch#1494boegel merged 3 commits intoeasybuilders:developfrom
Conversation
|
We have something similar in our setup, but it does this:
Looks to me like a bit better, since it will replace it just when linking. |
|
@MisterFruits Thoughts on @damianam's suggestion? Looks cleaner to me too... |
|
I have to say that I'm not a PGI expert ;) eventually looks cleaner yes ! I'll update the PR but I won't be able to test |
Upon suggestion of @damianam, see easybuilders#1494
| # contents for siterc file to make PGI accept the -pthread switch | ||
| # cf. https://www.pgroup.com/userforum/viewtopic.php?t=5253&sid=93356f | ||
| SITERC_PTHREAD_SWITCH = """ | ||
| # allow -pthread switch stands for -lpthread |
There was a problem hiding this comment.
I think "replace unknown switch -pthread with -lpthread" is a clearer comment.
| self.log.info("Appended instructions to pick up $LIBRARY_PATH to siterc file at %s: %s", | ||
| siterc_path, SITERC_LIBRARY_PATH) | ||
| write_file(siterc_path, SITERC_PTHREAD_SWITCH, append=True) | ||
| self.log.info("Appended instructions to allow -pthread switch to siterc file at %s: %s", |
There was a problem hiding this comment.
And "Append instructions to replace -pthread with -lpthread to siterc file at ..." feels better to me.
|
Have tested with and without this change, result with change is excellent. |
|
Thanks @MisterFruits! |
|
Going in, thanks @MisterFruits |
fix #1493