make IntelBase generic easyblock aware of (pre)installopts#1509
Merged
boegel merged 3 commits intoeasybuilders:developfrom Sep 15, 2018
Merged
make IntelBase generic easyblock aware of (pre)installopts#1509boegel merged 3 commits intoeasybuilders:developfrom
boegel merged 3 commits intoeasybuilders:developfrom
Conversation
Member
Author
|
Verified with an extended dry run using easybuilders/easybuild-easyconfigs#6841 |
Member
|
@ocaisa Doesn't it make sense to also pick up |
boegel
requested changes
Sep 14, 2018
| # perform installation | ||
| cmd = "./install.sh %s -s %s" % (tmppathopt, silentcfg) | ||
| cmd = "%s ./install.sh %s -s %s %s" % (self.cfg['preinstallopts'], tmppathopt, silentcfg, | ||
| self.cfg['installopts']) |
Member
There was a problem hiding this comment.
@ocaisa Let's reformat this while we're at it:
cmd = ' '.join([
self.cfg['preinstallopts'],
'./install.sh',
tmppathopt,
'-s ' + silentcfg,
self.cfg['installopts'],
])
Member
Author
|
Verified again with an extended dry run and easybuilders/easybuild-easyconfigs#6841 |
boegel
approved these changes
Sep 15, 2018
Member
|
Thanks @ocaisa! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1501