Skip to content

also specify --host option to configure script based on config.guess result in ConfigureMake easyblock#1532

Merged
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:configuremake_host_type
Sep 28, 2018
Merged

also specify --host option to configure script based on config.guess result in ConfigureMake easyblock#1532
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:configuremake_host_type

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 27, 2018

@boegel boegel added this to the 3.7.1 milestone Sep 27, 2018
@boegel boegel requested a review from ocaisa September 28, 2018 05:47
@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Sep 28, 2018

All this does is enforce the default behaviour, I see no problem.

Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit 9dff7fa into easybuilders:develop Sep 28, 2018
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 28, 2018

@micaeljtoliveira Given your feedback in easybuilders/easybuild-easyconfigs#6922, thoughts on this change, do you agree it makes sense to set both --build & --host, regardless of the buggy way in which the Hypre configure script is "written"?

@micaeljtoliveira
Copy link
Copy Markdown
Contributor

@boegel I'm no expert in cross-compilation or this specific part of the autotools, but if their documentation is to be trusted, setting both --build and --host should be fine. Personally I would avoid doing this systematically as a workaround for a bug in a specific package and I would patch Hypre instead, but this is obviously up to you.

In case you are wondering, this is how the patch should look like for Hypre 2.11.2 (assuming I understood the problem correctly):

2330a2331,2332
> if test "x$build_alias" = "x"
> then
2367a2370,2374
> 
> fi
> 
> if test "x$host_alias" = "x"
> then
2399a2407,2409
> 
> fi
> 
7230c7240
<    if test $host = $build
---
>    if test $host_alias = $build_alias

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 28, 2018

@micaeljtoliveira Thanks for the feedback, much appreciated!

This problem may not be specific to Hypre at all, who knows... I'm pretty sure there's software out there we haven't played with yet. ;)

Also, since there should be no harm in setting both (especially since it doesn't prevent you from actually cross-compiling thanks to the build_type and host_type easyconfig parameters now supported by ConfigureMake), I think this is fine.

This approach has the added benefit that we don't need to touch the Hypre easyconfigs (which worked fine before we started setting (only) --build), and I couldn't find a clear reference to people reporting the invalid value of canonical host error for Hypre, so it seems to me we're in uncharted territory when only setting --build, which scares me a bit...

I agree with you that it's not entirely clear what the best way forward is here. But my gut feeling (which may be wrong, time will tell) suggests that also setting --host in ConfigureMake will result in less headaches going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants