use short module name when creating module wrapper in ModuleRC generic easyblock#1535
Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom Oct 1, 2018
Conversation
Member
Author
|
fix confirmed by @guest1604 in #1534 |
migueldiascosta
approved these changes
Oct 1, 2018
Member
migueldiascosta
left a comment
There was a problem hiding this comment.
reproduced issue and verified fix, lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #1534
cc @guest1604, @zao