add symlink to wrapped module file when creating .modulerc in temporary location#1539
Merged
vanzod merged 1 commit intoeasybuilders:developfrom Oct 9, 2018
Merged
Conversation
boegel
commented
Oct 4, 2018
| modulerc = os.path.join(os.path.dirname(modfile_path), self.module_generator.DOT_MODULERC) | ||
|
|
||
| if os.path.exists(modulerc) and not build_option('force'): | ||
| raise EasyBuildError("Found existing file at %s, not overwriting without --force", modulerc) |
Member
Author
There was a problem hiding this comment.
This check is now being done in the ModuleGenerator.modulerc method (see easybuilders/easybuild-framework#2611), so no point in doing it again here.
This was referenced Oct 4, 2018
damianam
reviewed
Oct 9, 2018
vanzod
approved these changes
Oct 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for problem reported by @zao in easybuilders/easybuild#462 and by @verdurin in easybuilders/easybuild-easyconfigs#6906
requires easybuilders/easybuild-framework#2611