Skip to content

use os.getcwd() rather than self.startdir in TensorFlow easyblock to fix installation of TensorFlow as extension in a bundle#1540

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:tensorflow_ext
Oct 9, 2018
Merged

use os.getcwd() rather than self.startdir in TensorFlow easyblock to fix installation of TensorFlow as extension in a bundle#1540
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:tensorflow_ext

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 9, 2018

self.start_dir doesn't point to the correct location when TensorFlow is being installed as an extension...

This is a backward-compatible change, I've verified that with existing easyconfigs where TensorFlow is installed stand-alone.

…fix installation of TensorFlow as extension in a bundle
@boegel boegel added the bug fix label Oct 9, 2018
@boegel boegel added this to the 3.7.1 milestone Oct 9, 2018
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akesandgren akesandgren merged commit 8f56e3c into easybuilders:develop Oct 9, 2018
@boegel boegel deleted the tensorflow_ext branch October 9, 2018 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants