ENH: update WRF and WPS to support version 4#1563
Merged
boegel merged 8 commits intoeasybuilders:developfrom Nov 7, 2018
Merged
ENH: update WRF and WPS to support version 4#1563boegel merged 8 commits intoeasybuilders:developfrom
boegel merged 8 commits intoeasybuilders:developfrom
Conversation
Both WRF and WPS saw quite some changes in version 4.0. This commit adapts the existing WPS and WRF easyblocks to accomodate them.
houndci-bot
reviewed
Oct 28, 2018
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 7, in
from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
boegel
requested changes
Oct 28, 2018
houndci-bot
reviewed
Oct 29, 2018
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 7, in
from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
akesandgren
requested changes
Oct 29, 2018
avoid duplicate code for determining correct subdirectory in WRF/WPS easyblocks
akesandgren
requested changes
Nov 5, 2018
akesandgren
reviewed
Nov 5, 2018
Member
|
@akesandgren Are you OK with current status on this? |
akesandgren
requested changes
Nov 7, 2018
Contributor
|
Still 2 things to change, chdir/remove_dir order and the comment about 2D tests |
Contributor
Author
|
sorry, forgot to push. should include everything now. |
Contributor
|
@boegel I'm ok with this. It's your change requests that are blocking. |
boegel
approved these changes
Nov 7, 2018
Member
|
Thanks a lot for the updates @andreas-h! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both WRF and WPS saw quite some changes in version 4.0. This commit
adapts the existing WPS and WRF easyblocks to accomodate them.