enhance sanity check for icc & ifort: also check for compilers_and_libraries_*/linux subdirectory#1577
Merged
bartoldeman merged 1 commit intoeasybuilders:developfrom Nov 13, 2018
Conversation
…braries_*/linux subdirectory
Member
Author
|
Should be fully backwards compatible w.r.t. existing
|
bartoldeman
approved these changes
Nov 13, 2018
Contributor
bartoldeman
left a comment
There was a problem hiding this comment.
lgtm, no issues found reading the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
iccandiforteasyblocks heavily rely on thecompilers_and_libraries_%(version)s/linuxsubdirectory being there when generating the module file.If the directory is not there as expected, for example because the wrong version was used, then the generated module file is crippled.
We already have a check in place that catches this issue (the
which iccbeing run in the sanity check), but it's worthwhile to also have an explicit check for this subdirectory, since that results in a clearer error message, and you're likely to quickly figure out what's wrong.