avoid hardcoding --with-rdma configure option in MVAPICH2 easyblock#1586
Merged
damianam merged 2 commits intoeasybuilders:developfrom Nov 26, 2018
Merged
avoid hardcoding --with-rdma configure option in MVAPICH2 easyblock#1586damianam merged 2 commits intoeasybuilders:developfrom
damianam merged 2 commits intoeasybuilders:developfrom
Conversation
boegel
commented
Nov 16, 2018
| if self.cfg['rdma_type']: | ||
| add_configopts.append('--with-rdma=%s' % self.cfg['rdma_type']) | ||
| else: | ||
| add_configopts.append('--without-rdma') |
Member
Author
There was a problem hiding this comment.
Hmm, when testing this with the existing MVAPICH2-2.0.1-GCC-4.8.4.eb, I ran into this:
configure: error: The specified RDMA type is not supported
@peterinl: Maybe --without-rdma is not sufficient? Should this be something different?
Member
There was a problem hiding this comment.
The documentation and the configure don't mention anything about --without-rdma. That is probably not an option. I would simply remove the else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for problem reported by @peterinl via #7167
With this change included, you can avoid that
--with-rdmais used by settingrdma_type = Noneorrdma_type = ''orrdma_type = Falsein theMVAPICH2easyconfig file.