Skip to content

avoid hardcoding --with-rdma configure option in MVAPICH2 easyblock#1586

Merged
damianam merged 2 commits intoeasybuilders:developfrom
boegel:MVAPICH2_rdma
Nov 26, 2018
Merged

avoid hardcoding --with-rdma configure option in MVAPICH2 easyblock#1586
damianam merged 2 commits intoeasybuilders:developfrom
boegel:MVAPICH2_rdma

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 16, 2018

fix for problem reported by @peterinl via #7167

With this change included, you can avoid that --with-rdma is used by setting rdma_type = None or rdma_type = '' or rdma_type = False in the MVAPICH2 easyconfig file.

Comment thread easybuild/easyblocks/m/mvapich2.py Outdated
if self.cfg['rdma_type']:
add_configopts.append('--with-rdma=%s' % self.cfg['rdma_type'])
else:
add_configopts.append('--without-rdma')
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, when testing this with the existing MVAPICH2-2.0.1-GCC-4.8.4.eb, I ran into this:

configure: error: The specified RDMA type is not supported

@peterinl: Maybe --without-rdma is not sufficient? Should this be something different?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation and the configure don't mention anything about --without-rdma. That is probably not an option. I would simply remove the else

@peterinl
Copy link
Copy Markdown

peterinl commented Nov 16, 2018 via email

Copy link
Copy Markdown
Member

@damianam damianam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, going in!

@damianam damianam merged commit b75b564 into easybuilders:develop Nov 26, 2018
@boegel boegel deleted the MVAPICH2_rdma branch November 27, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants