Skip to content

fix bug in NEURON/numpy/DOLFIN easyblocks + refactor Python package easyblock#161

Merged
boegel merged 7 commits intoeasybuilders:developfrom
boegel:neuron
Mar 29, 2013
Merged

fix bug in NEURON/numpy/DOLFIN easyblocks + refactor Python package easyblock#161
boegel merged 7 commits intoeasybuilders:developfrom
boegel:neuron

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 28, 2013

No description provided.

Comment thread easybuild/easyblocks/d/dolfin.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not a fan of cd -

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ulimit -t 60 doesn't work either, since the test hangs but doesn't consume any CPU time. Suggestions here?

Would curdir=$PWD and cd $curdir be better as opposed to cd -?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not cd %(somevariable)s? or do you have no clue where it is exectuded? if not, yes, your proposal is better.

FC18 coreutils provides /usr/bin/timeout, vsc-base will have a timeout run hpcugent/vsc-base#44 (you could backport the code to run_run, but i'm no big fan)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeout is not available on SL5...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 29, 2013

Excluded DOLFIN's Python tests for now, until easybuilders/easybuild-framework#581 is fixed which will provide decent timeout supports for running commands.

@stdweird: Does this need to looked over again before it gets merged in?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 29, 2013

Retested build of NEURON, numpy, scipy and DOLFIN with this patch included, works fine.

Two people went through this, no major remarks, so merging it in.

boegel added a commit that referenced this pull request Mar 29, 2013
fix bug in NEURON/numpy/DOLFIN easyblocks + refactor Python package easyblock
@boegel boegel merged commit d58456d into easybuilders:develop Mar 29, 2013
@boegel boegel deleted the neuron branch March 29, 2013 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants