Handle multiple installation keys for MATLAB#1610
Merged
boegel merged 4 commits intoeasybuilders:developfrom Jan 13, 2019
Merged
Handle multiple installation keys for MATLAB#1610boegel merged 4 commits intoeasybuilders:developfrom
boegel merged 4 commits intoeasybuilders:developfrom
Conversation
One can have multiple installation keys tyo matlab, if so one has to do one install per key. Matlab installer ignores TMPDIR, give it a -tmpdir option if needed. Don't add JAVA_OPTIONS to the module file if there are no java_options.
boegel
requested changes
Dec 20, 2018
If not it uses /tmp.
boegel
requested changes
Jan 8, 2019
boegel
requested changes
Jan 12, 2019
Member
boegel
left a comment
There was a problem hiding this comment.
@akesandgren Fails because of missing import tempfile:
File "/tmp/eb-FDSg1Q/included-easyblocks/easybuild/easyblocks/matlab.py", line 132, in install_step
tmpdir = "-tmpdir %s" % tempfile.mkdtemp()
NameError: global name 'tempfile' is not defined
How did this ever work in your tests? ;)
boegel
approved these changes
Jan 13, 2019
Member
|
lgtm, tested, so good to go, thanks @akesandgren! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One can have multiple installation keys to matlab, if so one has to do
one install per key.
Matlab installer ignores TMPDIR (always using /tmp), give use the -tmpdir option.
Don't add JAVA_OPTIONS to the module file if there are no java_options.