make sure CMake doesn't pick up on system Boost in CMakeMake generic easyblock (#1618
Conversation
|
This only works for CmakeFiles that uses CMakes builtin search for Boost. And there might be situations where this is the wrong thing to do. |
|
@akesandgren If it doesn't work then it is doing no harm so I think it should be on by default, but for individual easyconfigs I don't see an issue with being able to switch it off |
| # - instruct CMake to not search for Boost headers/libraries in other places | ||
| # - disable search for Boost CMake package configuration file | ||
| boost_root = get_software_root('Boost') | ||
| if boost_root: |
There was a problem hiding this comment.
Add an option enable_system_boost with a default of false so this can be switched off in a corner case.
Also, should we care that this may only be relevant to versions of CMake that supported this functionality?
There was a problem hiding this comment.
Looks like Find_Boost goes back to 2.8.4 (oldest in EB) so should be fine
…et to False by default) to allow picking up of system Boost even when Boost is listed as a dependency
|
I've tested this quite extensively, haven't hit any problems at all, so this is good to go imho... |
fix for #1608 raised by @bartoldeman
I tested this with a couple of easyconfigs that use
CMakeMakeand haveBoostas a dependency, seems to work as expected, but more extensive testing is needed.I also wonder whether there is a more general approach to take here, why only do this for
Boost?