modified configuremake and cmakemake to allow changing configure_cmd,…#1628
Merged
boegel merged 5 commits intoeasybuilders:developfrom Mar 14, 2019
Merged
Conversation
… build_cmd and install_cmd to fit various needs
boegel
requested changes
Mar 8, 2019
Member
|
@mboisson Looks like you have a merge conflict to fix as well... |
Contributor
Author
I merged easybuilders-develop into this branch. |
…commands in ConfigureMake and CMakeMake easyblocks
boegel
requested changes
Mar 14, 2019
| command = ' '.join([self.cfg['preconfigopts'], 'cmake', options_string, self.cfg['configopts'], srcdir]) | ||
| command = ' '.join([ | ||
| self.cfg['preconfigopts'], | ||
| self.cfg['configure_cmd'], |
Member
There was a problem hiding this comment.
@mboisson We should be a bit more careful here, and use self.cfg.get, see ComputeCanada#2
use self.cfg.get to fetch (now configurable) configure/build/install commands in ConfigureMake and CMakeMake easyblocks
Contributor
Author
|
merged, but that created conflicts |
Member
|
@mboisson Actually, the conflict was already there before you merged my PR... |
Contributor
Author
|
Mmmm, it wasn't there 5 days ago, I merged easybuilders/develop into this branch 5 days ago |
Member
boegel
approved these changes
Mar 14, 2019
Member
|
Going in, thanks @mboisson! |
This was referenced Mar 14, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… build_cmd and install_cmd to fit various needs
This is for what we discussed over Slack, to allow to change, for example, "make install" by "ninja install" in one case.
Tagging @boegel and @akesandgren