make ConfigureMake, MesonNinja and SCons generic easyblock aware of pretestopts#1645
Conversation
|
This makes easybuilders/easybuild-easyconfigs#7762 work if one adds |
boegel
left a comment
There was a problem hiding this comment.
Same remark applies to other tweaked easyblocks as well.
|
|
||
| if self.cfg['runtest']: | ||
| cmd = "make %s" % (self.cfg['runtest']) | ||
| cmd = "%s make %s" % (self.cfg['pretestopts'], self.cfg['runtest']) |
There was a problem hiding this comment.
@akesandgren Also pick up on testopts while you're at it?
cmd = ' '.join([self.cfg['pretestopts'], "make %s" % self.cfg['runtest'], self.cfg['testopts']])There was a problem hiding this comment.
I left that out because you can basically set runtest to include any othe options you need to have.
So I'm not sure that there is a reason for testopts.
There was a problem hiding this comment.
In some contexts, runtest can be a boolean (I think for Python packages), so we should allow both runtest and testopts to compose the test command, I see no reason not to.
There was a problem hiding this comment.
Ok, will fix for the ones i changed already. Leaving the more complicated ones for later.
|
lgtm, thanks @akesandgren! |
No description provided.