Make serial, smpar and dm+sm builds of WRF work and pass tests.#1646
Merged
wpoely86 merged 4 commits intoeasybuilders:developfrom Mar 13, 2019
Merged
Make serial, smpar and dm+sm builds of WRF work and pass tests.#1646wpoely86 merged 4 commits intoeasybuilders:developfrom
wpoely86 merged 4 commits intoeasybuilders:developfrom
Conversation
run_test only checks rsl.error.0000 which isn't created for a serial run.
parallel_build_types implies MPI.
boegel
reviewed
Mar 3, 2019
| # fetch selected build type (and make sure it makes sense) | ||
| known_build_types = ['serial', 'smpar', 'dmpar', 'dm+sm'] | ||
| self.parallel_build_types = ["dmpar", "smpar", "dm+sm"] | ||
| self.parallel_build_types = ["dmpar", "dm+sm"] |
Member
There was a problem hiding this comment.
@akesandgren This doesn't look OK to me... smpar is a parallel build type, isn't it?
Contributor
Author
There was a problem hiding this comment.
No, the parallel build type only applies to MPI builds, basically it's used to decide which tests to run and if mpirun is to be used. It's not used for building stuff. So a more correct name would have been mpi_build_types.
"bt" is used in a regexp to find correct answer to build option.
houndci-bot
reviewed
Mar 3, 2019
wpoely86
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_test only checks rsl.error.0000 which isn't created for a serial run.