ALADIN bug fix: catch question for libgrib_api.a location instead of ignoring it#165
Merged
boegel merged 6 commits intoeasybuilders:v1.3.xfrom Mar 31, 2013
Merged
ALADIN bug fix: catch question for libgrib_api.a location instead of ignoring it#165boegel merged 6 commits intoeasybuilders:v1.3.xfrom
boegel merged 6 commits intoeasybuilders:v1.3.xfrom
Conversation
Contributor
There was a problem hiding this comment.
from what I understand, there was a convoluted mix-up of the api & api_f90 cases;
if so, it all looks good now, AFAI can tell... green light from this side.
Member
Author
There was a problem hiding this comment.
It wasn't really a mixup exactly.
Specifying the location of libgrib_api_f90.a is always required, and sometimes (apparently) the location of libgrib_api.a is also requested.
Most of the time, the latter is automatically derived from the former whoever, and you just have to confirm the correctness of the derived value (which is handled by another regex).
This patch fixes the sometimes case, which I ran into during the regtests prior to v1.3.0.
boegel
added a commit
that referenced
this pull request
Mar 31, 2013
ALADIN bug fix: catch question for libgrib_api.a location instead of ignoring it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the ALADIN build procedure asks explicitly for the
libgrib_api.alocation, the other time it derives it by itself and just requests to confirm correctness.This patch now also answers the explicit question properly.