Skip to content

Make sure Perl scripts are installed in the right location#1660

Merged
damianam merged 5 commits intoeasybuilders:developfrom
ocaisa:perl_scripts
Mar 26, 2019
Merged

Make sure Perl scripts are installed in the right location#1660
damianam merged 5 commits intoeasybuilders:developfrom
ocaisa:perl_scripts

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Mar 19, 2019

Should fix #1659

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Mar 20, 2019

@willfurnass Can you give these changes your seal of approval?

@willfurnass
Copy link
Copy Markdown
Contributor

willfurnass commented Mar 21, 2019

@ocaisa Yep, although not sure if setting installdir and scriptdirexp to the same path will cause problems for those using AFS - see https://perldoc.perl.org/Config.html

@boegel boegel added the bug fix label Mar 22, 2019
@boegel boegel added this to the next release (3.8.2) milestone Mar 22, 2019
Comment thread easybuild/easyblocks/p/perl.py Outdated
def extra_options():
"""Add extra config options specific to Perl."""
extra_vars = {
'force_scripts_installdir': [False, "Force all scripts to be installed in the installation bin directory "
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False is backwards compatible, True would automatically solve this problem and probably does no harm...but I can't be sure.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocaisa I see no reason to not always do this... scripts to into <prefix>/bin by default anyway, right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider that any of these scripts not ending up in $EBROOTPERL/bin is a bug and therefore I wouldn't worry about backwards compatibility. I wouldn't make this change optional either. @boegel ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel boegel changed the title Make sure perl scripts are installed in the right location Make sure Perl scripts are installed in the right location Mar 26, 2019
always specify -Dinstallscript and -Dscriptdir* configure options for Perl
Copy link
Copy Markdown
Member

@damianam damianam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damianam damianam merged commit 5d669cc into easybuilders:develop Mar 26, 2019
@ocaisa ocaisa deleted the perl_scripts branch October 27, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants