Skip to content

Make sure perl install dir follows a standard format#1708

Merged
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:perl_installdir
May 3, 2019
Merged

Make sure perl install dir follows a standard format#1708
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:perl_installdir

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented May 2, 2019

Fixes #1700

@ocaisa ocaisa mentioned this pull request May 2, 2019
Closed
@timeu
Copy link
Copy Markdown

timeu commented May 2, 2019

Doesn't this also require the exts_default_options = {'configopts': ''} statement ?

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented May 2, 2019 •
edited
Loading

No, this is specifically for the perl installation, the perl extensions are handled by another easyblock (which is unaffected by this change)
With this change you wouldn't need either of the options you had to include in your easyconfig solution.

@timeu
Copy link
Copy Markdown

timeu commented May 2, 2019

@ocaisa : Ah I understand, makes sense Thanks for clarifying !

@boegel
Copy link
Copy Markdown
Member

boegel commented May 2, 2019

@timeu Can you re-test with an unmodified Perl easyconfig (so without the changes used in #1700 to dance around the problem) with this patched easyblock (using eb --include-easyblocks perl.py ...), to confirm the fix?

@boegel boegel added the bug fix label May 2, 2019
@boegel boegel added this to the next release (3.9.1) milestone May 2, 2019
boegel
boegel requested changes May 2, 2019
View reviewed changes
Comment thread easybuild/easyblocks/p/perl.py Outdated
boegel
boegel approved these changes May 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, rebuilding Perl-5.28.1-GCCcore-8.2.0.eb on top of this didn't cause any problems...

@timeu
Copy link
Copy Markdown

timeu commented May 3, 2019

@boegel Do you still need me to test it ?

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented May 3, 2019 •
edited
Loading

@timeu Yes, can you retest please just so we know it actually does fix the problem

@timeu
Copy link
Copy Markdown

timeu commented May 3, 2019

Ok tried it with the unmodified easyconfig and the patched easyblock and it seems to work:

[easybuild@stg-login-0 Perl]$ eb Perl-5.28.1-GCCcore-8.2.0.eb --include-easyblocks /software/system/easyblocks/perl.py --force
== temporary log file in case of crash /tmp/eb-lvfRPB/easybuild-4F4MKc.log
== processing EasyBuild easyconfig /software/system/easyconfigs/easybuild/easyconfigs/p/Perl/Perl-5.28.1-GCCcore-8.2.0.eb
== building and installing perl/5.28.1-gcccore-8.2.0...
== fetching files...
== creating build dir, resetting environment...
== unpacking...
...
== installing extension App::cpanminus 1.7044 (289/289)...
== restore after iterating...
== postprocessing...
== sanity checking...
== cleaning up...
== creating module...
== permissions...
== packaging...
== COMPLETED: Installation ended successfully
== Results of the build can be found in the log file(s) /software/2019/software/perl/5.28.1-gcccore-8.2.0/easybuild/easybuild-Perl-5.28.1-20190503.121419.log
== Build succeeded for 1 out of 1
== Temporary log file(s) /tmp/eb-lvfRPB/easybuild-4F4MKc.log* have been removed.
== Temporary directory /tmp/eb-lvfRPB has been removed.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 3, 2019

Thanks a lot for confirming the fix @timeu!

@boegel boegel merged commit 7669979 into easybuilders:develop May 3, 2019
@ocaisa ocaisa deleted the perl_installdir branch October 27, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ocaisa @timeu @boegel