fix prefix in impi compiler wrappers#1727
Merged
boegel merged 2 commits intoeasybuilders:developfrom May 17, 2019
Merged
Conversation
…oving the installation. In the intel wrappers this was hidden by the fact that I_MPI_ROOT overrides the prefix. But the gcc wrappers are buggy and don't allow the override, hence this failed
boegel
approved these changes
May 15, 2019
Member
boegel
left a comment
There was a problem hiding this comment.
lgtm, but will give this a test spin first before merging it in
boegel
requested changes
May 16, 2019
Member
|
I've tested this with a range of
|
boegel
approved these changes
May 17, 2019
Member
|
Thanks for the fix @damianam! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patches the prefix directory, which is no longer correct after m…oving the installation. In the intel wrappers this was hidden by the fact that
I_MPI_ROOToverrides the prefix. But the gcc wrappers are buggy and don't allow the override, hence they failed.Thanks @bsteinb for the help diagnosing it!