rebuild internal libfabric for impi 2019.x & more recent#1730
rebuild internal libfabric for impi 2019.x & more recent#1730bartoldeman merged 3 commits intoeasybuilders:developfrom
Conversation
…better fit the running system
| os.chdir(os.path.join(self.installdir, 'libfabric')) | ||
| extract_file('src.tgz', './') | ||
| libfabric_installpath = os.path.join(self.installdir, 'intel64', 'libfabric') | ||
| cmds = [ |
There was a problem hiding this comment.
I don't particularly like recreating ConfigureMake here, but it might be better than importing another easyblock. That looks even more awkward.
There was a problem hiding this comment.
Yeah, it may be difficult to leverage ConfigureMake here, since you'll need to convince it to not pick up on configopts, buildopts, etc. Also, lot's of the logic in there is totally irrelevant here.
This isn't too terrible (and chances are that the build procedure for libfabric will change anyway)...
| os.chdir(os.path.join(self.installdir, 'libfabric')) | ||
| extract_file('src.tgz', './') | ||
| libfabric_installpath = os.path.join(self.installdir, 'intel64', 'libfabric') | ||
| cmds = [ |
There was a problem hiding this comment.
Yeah, it may be difficult to leverage ConfigureMake here, since you'll need to convince it to not pick up on configopts, buildopts, etc. Also, lot's of the logic in there is totally irrelevant here.
This isn't too terrible (and chances are that the build procedure for libfabric will change anyway)...
|
@damianam Maybe also add a comment above the |
|
I'm a little bit hesitant to enable re-building of @bartoldeman Can you take this for a spin with |
|
LGTM. I have tested it with |
|
Builds fine for me too, even on CentOS-6 with |
…better fit the running system