Skip to content

also add --without-go configure option for SWIG as we ''disable everything by default"#1754

Merged
boegel merged 1 commit intoeasybuilders:developfrom
jose-d:patch-1
Jul 1, 2019
Merged

also add --without-go configure option for SWIG as we ''disable everything by default"#1754
boegel merged 1 commit intoeasybuilders:developfrom
jose-d:patch-1

Conversation

@jose-d
Copy link
Copy Markdown
Contributor

@jose-d jose-d commented Jun 14, 2019

..as we here

disable everything by default

we should disable go too.

tested on SWIG SWIG-3.0.12-foss-2018b-Python-2.7.15.eb and SWIG-4.0.0-foss-2019a-Python-2.7.15.

..and as we here
> disable everything by default
we should disable go too.

tested on SWIG `SWIG-3.0.12-foss-2018b-Python-2.7.15.eb` and `SWIG-4.0.0-foss-2019a-Python-2.7.15`.
@jose-d jose-d changed the title add --without-go as we ''disable everything by default" SWIG: add --without-go as we ''disable everything by default" Jun 14, 2019
@boegel boegel added this to the next release (3.9.3) milestone Jul 1, 2019
@boegel boegel added the bug fix label Jul 1, 2019
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title SWIG: add --without-go as we ''disable everything by default" also add --without-go configure option for SWIG as we ''disable everything by default" Jul 1, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 1, 2019

Tested with several SWIG easyconfigs, incl. an ancient one for SWIG 2.0.4, works like a charm, thanks @jose-d!

@boegel boegel merged commit 02bb927 into easybuilders:develop Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants